RFR: 8159055: ImageIcon setImage and constructor can't handle null parameter [v9]

Abhishek Kumar abhiscxk at openjdk.org
Tue Jun 17 12:25:29 UTC 2025


On Tue, 17 Jun 2025 10:08:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates `MediaTracker` to associate the null image to that `id` and checks the status of loading this null image, removes the null image from the tracker and then tries to get the image width where it throws NPE as image is null.
>> 
>> It's better to not go through all MediaTracker usage and bail out initially itself for null image..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   SUmmary fix

Marked as reviewed by abhiscxk (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25767#pullrequestreview-2935437506


More information about the client-libs-dev mailing list