RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v5]

[Damon Nguyen]

On Tue, 17 Jun 2025 14:08:44 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rearrange and update test.
>
> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 44:
> 
>> 42:     static Frame testFrame;
>> 43:     static Frame instructionsFrame;
>> 44:     static CountDownLatch countDownLatch;
> 
> Suggestion:
> 
>     private static final CountDownLatch countDownLatch = new CountDownLatch(1);

Updated

> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 57:
> 
>> 55: 
>> 56:     static void createTestFrame() {
>> 57:         Frame frame = new Frame("Cursor change after drag");
> 
> You didn't assign it to `testFrame`, therefore this frame is never disposed of, and the test doesn't exit cleanly if run without jtreg.
> 
> In fact, I suggest returning the frame from `createTestFrame` and assigning it to the variable in the `main` method in the lambda expression that calls the method. The same applies to the `createInstructionsFrame` method.

Thanks for catching this!

> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 105:
> 
>> 103:         Panel btnPanel = new Panel();
>> 104:         Button passBtn = new Button("PASS");
>> 105:         Button failBtn = new Button("FAIL");
> 
> Suggestion:
> 
>         Button passBtn = new Button("Pass");
>         Button failBtn = new Button("Fail");
> 
> There's no reason ‘scream’.

Very true.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2152702112
PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2152704839
PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2152703824