RFR: 8358623: Avoid unnecessary data copying in ICC_Profile [v2]

Harshitha Onkar honkar at openjdk.org
Tue Jun 17 17:16:30 UTC 2025


On Thu, 12 Jun 2025 05:31:19 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   theHeader -> data
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 807:
> 
>> 805:             System.arraycopy(data, 0, theHeader, 0, HEADER_SIZE);
>> 806:             verifyHeader(theHeader);
>> 807: 
> 
> In reference to the above comment , these lines may need to be reverted as verifyHeader(byte[] header) expects the header array and not the entire profile byte array.

This change is no longer applicable after the latest changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25650#discussion_r2152777040


More information about the client-libs-dev mailing list