RFR: 8359430: Test 'javax/swing/plaf/windows/bug4991587.java' automatically failed on Windows 2025 x64 with message "Failed. Compilation failed: Compilation failed"

Damon Nguyen dnguyen at openjdk.org
Wed Jun 18 19:32:38 UTC 2025


Compilation error on windows with `WindowsButtonUI` used. Replaced it with `BasicButtonUI` to maintain overriding the `paintText` method but this was not the same as Windows L&F buttons. I attempted to import `WindowsButtonUI` and extending it, but the class is `final`. Instead, I chose to add a LineBorder in the same way as when a Rectangle was drawn to keep the same test behavior. It seems the extra 1 pixel width is unnecessary now when testing, so the changes only include removing `MyButtonUI` and adding a LineBorder.

-------------

Commit messages:
 - Update test to not extend ButtonUI
 - Initial commit
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - Merge branch 'master' of github.com:DamonGuy/jdk
 - ... and 1 more: https://git.openjdk.org/jdk/compare/a377773f...63255619

Changes: https://git.openjdk.org/jdk/pull/25883/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25883&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8359430
  Stats: 20 lines in 1 file changed: 0 ins; 17 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/25883.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25883/head:pull/25883

PR: https://git.openjdk.org/jdk/pull/25883


More information about the client-libs-dev mailing list