RFR: 8358697: java/awt/font/TextLayout/MyanmarTextTest.java gives false positive result when preconditions not met [v4]

Phil Race prr at openjdk.org
Wed Jun 18 20:21:33 UTC 2025


On Wed, 18 Jun 2025 19:39:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added blank line before OS_NAME
>
> test/jdk/java/awt/font/TextLayout/MyanmarTextTest.java line 59:
> 
>> 57:     private static final String[] FONTS_WINDOWS = {"Myanmar Text", "Noto Sans Myanmar"};
>> 58:     private static final String[] FONTS_LINUX = {"Padauk", "Noto Sans Myanmar", "Myanmar Text"};
>> 59:     private static final String[] FONTS_MACOS = {"Myanmar MN", "Noto Sans Myanmar", "Myanmar Text"};
> 
> I'm unsure if Noto Sans fonts are installed by default on Windows or macOS.
> 
> Similarly, "Myanmar Text" is unlikely to be installed on Linux.
> 
> Since there's a list of possible fonts, the list could well be *platform-independent* — just look for a first match.

My comment was ONLY about Linux. I definitely didn't expect to see the fonts for other platforms updated.
They can be a list of one font.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25879#discussion_r2155424813


More information about the client-libs-dev mailing list