RFR: 8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java [v9]

[Damon Nguyen]

On Wed, 18 Jun 2025 19:20:32 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>The timer updates each second, which sends additional messages — the dragged cursor changes as soon as the displayed time updates.
> 
> Pause the timer, and the drag cursor doesn't change until you release the left mouse button.
> 
> Harshitha was close to discovering it.

That makes a lot of sense. I saw your updates on that issue as well. I guess we can use this workaround in this niche case if necessary. Thanks @aivanov-jdk and @honkar-jdk for your help in looking into this!

> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 46:
> 
>> 44:     static Frame instructionsFrame;
>> 45:     private static final CountDownLatch countDownLatch = new CountDownLatch(1);
>> 46:     static String INSTRUCTIONS = """
> 
> I'd place the fields in this order:
> 
> 
> INSTRUCTIONS
> 
> testFrame
> instructionsFrame
> 
> countDownLatch
> 
> 
> The blank lines are explicit for the code, too. This way the fields come in groups: the instructions describe what the tester will do, so it's reasonable to put them at the top, and this aligns to the most common way in manual tests; then go the two frames of the test; the latch which controls the test follows.
> 
> Personally, I'd also declare all of them `private`.

Implemented and noted!

> test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java line 114:
> 
>> 112:         Panel btnPanel = new Panel();
>> 113:         Button passBtn = new Button("PASS");
>> 114:         Button failBtn = new Button("FAIL");
> 
> Suggestion:
> 
>         Button passBtn = new Button("Pass");
>         Button failBtn = new Button("Fail");
> 
> Title case is good enough.

I thought I updated this already. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25705#issuecomment-2985950371
PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2155664742
PR Review Comment: https://git.openjdk.org/jdk/pull/25705#discussion_r2155657589