RFR: 8359687: Use PassFailJFrame for java/awt/print/Dialog/DialogType.java [v2]

Srinivas Mandalika smandalika at openjdk.org
Thu Jun 19 08:55:32 UTC 2025


On Wed, 18 Jun 2025 05:58:22 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added SkippedException when Printer is unavailable.
>
> test/jdk/java/awt/print/Dialog/DialogType.java line 52:
> 
>> 50:         Two dialogs are shown in succession.
>> 51:         The test passes as long as no exceptions are thrown, *AND*
>> 52:         if running on Windows only, the first dialog is a native windows
> 
> Windows specific can be as note or even you can append it to instructions on Windows OS check condition.

Reconfirmed by testing on Mac OS and Linux as well - both of these have different dialogs for first and second.
As suggested, added a note.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2156494972


More information about the client-libs-dev mailing list