RFR: 8159055: ImageIcon.setImage and ImageIcon(Image) constructor can't handle null parameter [v10]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Jun 20 03:53:31 UTC 2025


On Thu, 19 Jun 2025 03:01:15 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates `MediaTracker` to associate the null image to that `id` and checks the status of loading this null image, removes the null image from the tracker and then tries to get the image width where it throws NPE as image is null.
>> 
>> It's better to not go through all MediaTracker usage and bail out initially itself for null image..
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Test fix
>  - javadoc wording..clear image desscription if image is null

I have removed resetting "description" from constructor as it is already null there..Retained in setImage and reset width/height also..

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25767#issuecomment-2989719370


More information about the client-libs-dev mailing list