RFR: 8359430: Test 'javax/swing/plaf/windows/bug4991587.java' automatically failed on Windows 2025 x64 with message "Failed. Compilation failed: Compilation failed"

[Alexey Ivanov]

On Fri, 20 Jun 2025 03:22:46 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > It may be impossible to reproduce the problem without referencing WindowsButtonUI. If it's possible, I'm all for it.
> 
> That should be checked on old jdk build.

Exactly!

We have to reproduce the original bug first to see what was wrong.

> > The bug was in Windows L&F, I don't think it's applicable to other L&F.
> 
> It depends on how these offsets were used previously, maybe we displayed the text outside the button, which shouldn't happen for all L&Fs.

Yes, but…

This specific bug was for Windows only, the fix was presumably in Windows-only code, this is why I don't care much about other L&F.

Even if the text was displayed outside of the button, it *was* Windows-specific.

Until we understand what the original bug was, it is too early to extend the test to other L&F.

Additionally, it's a manual test. If the test is automated, it makes more sense to test for all L&Fs; for a manual test, I'd rather avoid testing in other L&F because the bug never existed there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25883#discussion_r2158861159