RFR: 8359687: Use PassFailJFrame for java/awt/print/Dialog/DialogType.java [v8]

Alexey Ivanov aivanov at openjdk.org
Fri Jun 20 18:55:28 UTC 2025


On Fri, 20 Jun 2025 16:28:08 GMT, Srinivas Mandalika <smandalika at openjdk.org> wrote:

>> Use PassFailJFrame to streamline the test java/awt/print/Dialog/DialogType.java, as is for several of the manual tests.
>> 
>> Modified Manual Test Passed when run using jtreg.
>
> Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Whitespace error

Just a small typo left.

test/jdk/java/awt/print/Dialog/DialogType.java line 52:

> 50:         On macOS & on Windows, the first dialog is a native
> 51:         dialog provided by the OS, the second dialog is
> 52:         implemented in Swing, the dialog differ in appearance.

Suggestion:

        implemented in Swing, the dialogs differ in appearance.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25842#pullrequestreview-2947052062
PR Review Comment: https://git.openjdk.org/jdk/pull/25842#discussion_r2159519911


More information about the client-libs-dev mailing list