RFR: 8355904: Use variadic macros for J2dTrace [v7]
duke
duke at openjdk.org
Fri Jun 20 20:42:33 UTC 2025
On Fri, 6 Jun 2025 08:36:40 GMT, Nikita Gubarkov <ngubarkov at openjdk.org> wrote:
>> J2dTrace macros have multiple overloads specifying number of arguments, making it less convent to change number of arguments. There were cases when existing macros were not enough and people had to add new variants with even more arguments. We could simply use variadic macros instead.
>>
>> Also, currently those macros expand to a { code block }, which doesn't require a semicolon at the end, so it can sometimes be missed, leading to an inconsistent code style. We could expand it directly to the function, forcing user to insert a semicolon after that, in a function-like style.
>
> Nikita Gubarkov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into JDK-8355904
> - Update D3DShaderGen.c
> - fixup! 8355904: Use variadic macros for J2dTrace
> - fixup! 8355904: Use variadic macros for J2dTrace
> - fixup! 8355904: Use variadic macros for J2dTrace
> - Apply suggestions from code review
>
> Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
> - fixup! 8355904: Use variadic macros for J2dTrace
> - 8355904: Use variadic macros for J2dTrace
@YaaZ
Your change (at version a4f9d118c21f61a205e0c3703602a6df42cd0fb0) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24949#issuecomment-2992742065
More information about the client-libs-dev
mailing list