RFR: 8008222: [macosx] selectNextChangeLead is not implemented for Tree in Aqua LAF [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed Jun 25 00:39:29 UTC 2025
On Tue, 24 Jun 2025 12:11:52 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> There is no shortcuts for selectNextChangeLead and selectPreviousChangeLead in Aqua LAF which updates [LEAD_SELECTION_PATH_PROPERTY](https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/swing/JTree.html#LEAD_SELECTION_PATH_PROPERTY).....
>> Other L&F uses "ctrl DOWN/UP" to selectNextChangeLead/selectPreviousChangeLead but same shortcut cannot be used in mac as "ctrl DOWN" shortcut is used to display the window of current active application while "ctrl UP" is used to display all windows of all applications which allows to switch between them
>> so used CTRL+SHIFT+DOWN for the selectNextChangeLead CTRL+SHIFT+UP for selectPreviousChangeLead
>>
>> No regression test as it can be verified through SwingSet2 demo as below..
>>
>> With ctrl+shift+down
>> <img width="124" alt="Screenshot 2025-06-19 at 1 41 39 PM" src="https://github.com/user-attachments/assets/8baa386e-b03a-4fd2-b5e2-4ac26157e5af" />
>>
>> another ctrl+shift+down
>> <img width="127" alt="Screenshot 2025-06-19 at 1 42 39 PM" src="https://github.com/user-attachments/assets/572a806c-4d54-4045-b92a-c1e88d403305" />
>>
>> Now, ctrl+shift+up
>> <img width="134" alt="Screenshot 2025-06-19 at 1 44 51 PM" src="https://github.com/user-attachments/assets/6d671852-f7b7-434f-8688-6c5dd4b3cdb5" />
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Add test
Is CTRL+SHIFT+(UP/DOWN) the correct key binding here?
I can mimic a Tree on MacOS using `Finder` and viewing as a `List View`. Looks like CTRL+SHIFT+(UP/DOWN) selects the next in that direction as well in a selection group. Here's a screenshot where I started on `Apple` and pressed CTRL+SHIFT+DOWN 5 times.
<img width="895" alt="Screenshot 2025-06-24 at 5 33 21 PM" src="https://github.com/user-attachments/assets/e3f1e4d3-6f52-485c-a89f-b07118116881" />
-------------
PR Review: https://git.openjdk.org/jdk/pull/25892#pullrequestreview-2955824696
PR Comment: https://git.openjdk.org/jdk/pull/25892#issuecomment-3002245908
More information about the client-libs-dev
mailing list