RFR: 6955128: Spec for javax.swing.plaf.basic.BasicTextUI.getVisibleEditorRect contains inappropriate wording [v2]

Alexey Ivanov aivanov at openjdk.org
Wed Jun 25 10:39:28 UTC 2025


On Wed, 25 Jun 2025 07:09:10 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> BasicTextUI.getVisibleEditorRect wording is rephrased to remove the wording "Due to an unfortunate set of historical events this method is inappropriately named".
>
> Prasanta Sadhukhan has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update javadoc
>  - Update javadoc
>  - Update javadoc

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line 1034:

> 1032:      * Gets the allocation for the root view.
> 1033:      * The returned rectangle is unrelated to visibility,
> 1034:      * and is used to set the size of the root view.

Suggestion:

     * The returned rectangle is unrelated to visibility.
     * It is used to set the size of the root view.

I still think, “it is used…” is clearer.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25850#pullrequestreview-2957623200
PR Review Comment: https://git.openjdk.org/jdk/pull/25850#discussion_r2166390088


More information about the client-libs-dev mailing list