RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v29]
Alexey Ivanov
aivanov at openjdk.org
Thu Jun 26 11:28:39 UTC 2025
On Thu, 26 Jun 2025 03:09:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 33 additional commits since the last revision:
>
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
> - Windows 10 offset correction without icon
> - Fix issue for presence of gap between buller and text only if atleast 1 menuitem has imageicon
> - Text alignment fix
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
> - Review comments fix
> - Expand wildcard imports
> - Remove unneeded methods
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
> - Code duplication removed
> - ... and 23 more: https://git.openjdk.org/jdk/compare/10fdd51a...ea1016fc
The layout for Windows 11 is still wrong and suffers from the same problems that [I raised yesterday](https://github.com/openjdk/jdk/pull/23324#issuecomment-3005372591). The entire popup menu looks the same way that [I posted about an hour ago](https://github.com/openjdk/jdk/pull/23324#issuecomment-3008030059).
The layout for Windows 10 is correct now.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-3008146432
More information about the client-libs-dev
mailing list