RFR: 8350924: javax/swing/JMenu/4213634/bug4213634.java fails [v2]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Tue Mar 4 07:45:43 UTC 2025
On Tue, 4 Mar 2025 06:33:23 GMT, Tejesh R <tr at openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Test fix
>
> test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 40:
>
>> 38: /*
>> 39: * @test
>> 40: * @key headful
>
> Can you please add the test summary.
Added
> test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 81:
>
>> 79: frame.setLocationRelativeTo(null);
>> 80: frame.setVisible(true);
>> 81: button.requestFocusInWindow();
>
> Since the root cause is unknown and you are trying to make the test more robust, should we add a delay after `frame.setVisible(true);` ? I'm just suspecting request focus failure after `setVisible`.
that's why I added waitForIdle/delay after createShowGUI
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1978804150
PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1978805579
More information about the client-libs-dev
mailing list