RFR: 8344892: beans/finder/MethodFinder.findMethod incorrectly returns null [v3]
Alexander Zvegintsev
azvegint at openjdk.org
Tue Mar 4 15:45:01 UTC 2025
On Mon, 3 Mar 2025 20:39:01 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> year update
>
> src/java.desktop/share/classes/com/sun/beans/finder/MethodFinder.java line 80:
>
>> 78:
>> 79: try {
>> 80: return CACHE.get(signature);
>
> Is it possible to create a test for this patch?
We have a slowdown [JDK-8350573](https://bugs.openjdk.org/browse/JDK-8350573) of the `java/beans/XMLDecoder/8028054/TestMethodFinder.java` test
The possible test would be to set a timeout for it, but is depends on the hardware:
> On my test machine the test runtime goes from ~ 40s (hash of the change before [JDK-8344891](https://bugs.openjdk.org/browse/JDK-8344891)) to ~ 1:40 ([JDK-8344891](https://bugs.openjdk.org/browse/JDK-8344891)) .
> Locally on my M1 Macbook pro this test runs in ~4 seconds before and in ~28 seconds after [JDK-8344891](https://bugs.openjdk.org/browse/JDK-8344891) change.
So I believe it would be better to track anomalies by test execution time history in the CI.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23845#discussion_r1979713655
More information about the client-libs-dev
mailing list