RFR: 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v2]

Phil Race prr at openjdk.org
Wed Mar 5 19:52:07 UTC 2025


On Wed, 5 Mar 2025 08:30:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8319192
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java line 249:
> 
>> 247:      */
>> 248:     private URL getResource(String path) {
>> 249:         return _classResourceBase.getResource(path);
> 
> Any particular reason for removing the null check?

Yes. the resource was *either* url-based or classpath based. One would be null, the other not.
Now there's only one, so it must be the non-null one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23909#discussion_r1982094177


More information about the client-libs-dev mailing list