RFR: 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v2]

[Phil Race]

On Wed, 5 Mar 2025 22:47:11 GMT, Phil Race <prr at openjdk.org> wrote:

> > It is also mentioned in
> > https://github.com/openjdk/jdk/blob/caaf4098452476d981183ad4302b76b9c883a72b/src/java.desktop/share/classes/javax/swing/plaf/synth/doc-files/synthFileFormat.html#L57-L58
> 
> Ah. I'd forgotten that. I had updated it back in JDK 21 but it slipped my mind this time round.

fixed

>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java line 223:
>> 
>>> 221:         }
>>> 222: 
>>> 223:         assert(classResourceBase != null);
>> 
>> It looks like this assert is no longer needed, because the `classResourceBase` is not null at this point.
>
> Fair enough. But I'm not sure it was ever needed. The condition in the existing code also ensured it would never fail.

fixed

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23909#issuecomment-2702278386
PR Review Comment: https://git.openjdk.org/jdk/pull/23909#discussion_r1982310621