RFR: 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v2]

Phil Race prr at openjdk.org
Wed Mar 5 23:07:07 UTC 2025


On Wed, 5 Mar 2025 22:38:59 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8319192
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java line 223:
> 
>> 221:         }
>> 222: 
>> 223:         assert(classResourceBase != null);
> 
> It looks like this assert is no longer needed, because the `classResourceBase` is not null at this point.

Fair enough. But I'm not sure it was ever needed. The condition in the existing code also ensured it would never fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23909#discussion_r1982309622


More information about the client-libs-dev mailing list