RFR: 8319192: Remove javax.swing.plaf.synth.SynthLookAndFeel.load(URL url) [v3]

Phil Race prr at openjdk.org
Thu Mar 6 20:55:00 UTC 2025


On Thu, 6 Mar 2025 00:11:26 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8319192
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java line 38:
> 
>> 36: import java.io.InputStream;
>> 37: import java.net.URL;
>> 38: import java.net.URLClassLoader;
> 
> Is URLClassLoader no longer used?

seems so. I'll remove it.

> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java line 216:
> 
>> 214:      * @param inputStream XML document containing the styles to read
>> 215:      * @param factory DefaultSynthStyleFactory that new styles are added to
>> 216:      * @param urlResourceBase the URL used to resolve any resources, such as Images
> 
> The description of this method includes information about the URL

The whole sentence is now unnecessary and can be deleted.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23909#discussion_r1984016598
PR Review Comment: https://git.openjdk.org/jdk/pull/23909#discussion_r1984033190


More information about the client-libs-dev mailing list