RFR: 8336382: Fix error reporting in loading AWT [v10]
Karm Michal Babacek
duke at openjdk.org
Sat Mar 8 00:23:02 UTC 2025
On Fri, 31 Jan 2025 13:33:13 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Amended error message, doesn't clear exception
>
> See https://bugs.openjdk.org/browse/JDK-8349099
>
> @Karm I was wondering why this did not show up on GHA (it's probably not executed there). But I noticed when researching this that your last merge from mainline was in September. Even if there are no "physical" merge conflicts that git can detect, there are likely to be "logical" conflicts like this, where a library was removed that your test depended on.
>
> So for a long running PR like this, when it is ready to be checked in, you need to merge in main and verify that the fix (and the tests) still works, and nothing else breaks. If there are no "physical" conflicts you do not need to push the merge to the PR on github, since that might invalidate approvals, but you need to test it locally.
>
> As for how long "long running" is, I don't know. A week without merge is likely okay, 3 months is not.
@magicus @aivanov-jdk
Thanks for the comments. I improved my flow; e.g. https://github.com/openjdk/jdk/pull/23852#issuecomment-2707082359
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2707770699
More information about the client-libs-dev
mailing list