RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v18]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Mar 10 13:15:00 UTC 2025


On Fri, 7 Mar 2025 17:56:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > FWIW the current fix isn't what I'd like to see.
> > > Putting a check for Windows L&F in a BasicUI class ?? We had a similar issue with GTK some months ago and it was something that we managed to avoid. Isn't there a Windows L&F sub-class we can do this in ??
> > 
> > 
> > Since the Windows L&F check in Basic*UI class is a bone of contention, I have removed it and put the code in Windows specific class although there's around 200+ lines of code duplication as most of the required helper methods in BasicMenuItemUI class has private access.. CI run in windows is ok..
> 
> Can we move these helper methods into a utility class which has public access to both `Basic*UI` and `Windows*UI`? `SwingUtilities3`, or a new class?

OK..Moved..PR updated

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2710554143


More information about the client-libs-dev mailing list