RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v13]

Harshitha Onkar honkar at openjdk.org
Mon Mar 10 23:39:56 UTC 2025


On Wed, 5 Mar 2025 20:55:45 GMT, Phil Race <prr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor
>
> test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck.java line 71:
> 
>> 69:             } catch (IllegalArgumentException iae) {
>> 70:                 if (!iae.getMessage().equals(EXCEPTION_MSG)) {
>> 71:                     throw new RuntimeException("Test Failed! IAE with exception msg \""
> 
> I don't think you need to - or should - expect a specific exception message.
> Obviously you can update the test if the text changes, but I just don't think this is necessary.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1988153762


More information about the client-libs-dev mailing list