RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v15]

[Harshitha Onkar]

On Tue, 11 Mar 2025 19:42:12 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review changes
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 116:
> 
>> 114:      * built-in profiles.
>> 115:      */
>> 116:     private transient final boolean builtIn;
> 
> Suggestion:
> 
>     private final transient boolean builtIn;
> 
> In [the ‘blessed’ modifier order](https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/lang/reflect/Modifier.html#toString(int)), `transient` follows `final`.

Updated

> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 783:
> 
>> 781:      * <p>
>> 782:      * Note: {@code ProfileDeferralInfo} is used for only built-in profile
>> 783:      * creation and all built-in profiles should be constructed using it.
> 
> Should we repeat the note in a comment for the `BuiltInProfile` interface or before the values?

Good idea. Added the note near to the location of usage.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1990131146
PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1990130873