RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v21]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Wed Mar 12 03:38:47 UTC 2025
> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 25 additional commits since the last revision:
- Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
- Code duplication removed
- Remove Windows L&F check from BasicMenuItemUI
- Review comment fix
- Test rename
- Revert to non-CSR needed fix
- Move windows specific change to windows folder
- Merge branch 'master' of https://git.openjdk.java.net/jdk into JDK-8348760
- comment
- Extend to Windows11 and later
- ... and 15 more: https://git.openjdk.org/jdk/compare/48d3ebba...03a08727
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23324/files
- new: https://git.openjdk.org/jdk/pull/23324/files/b5a91f51..03a08727
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=20
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23324&range=19-20
Stats: 75963 lines in 1498 files changed: 34914 ins; 28474 del; 12575 mod
Patch: https://git.openjdk.org/jdk/pull/23324.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23324/head:pull/23324
PR: https://git.openjdk.org/jdk/pull/23324
More information about the client-libs-dev
mailing list