RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]
Sergey Bylokhov
serb at openjdk.org
Fri Mar 14 02:05:52 UTC 2025
On Thu, 13 Mar 2025 15:45:12 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> header update
>
> make/modules/java.desktop/lib/ClientLibraries.gmk line 249:
>
>> 247: DISABLED_WARNINGS_clang_dgif_lib.c := sign-compare, \
>> 248: DISABLED_WARNINGS_clang_gzwrite.c := format-nonliteral, \
>> 249: DISABLED_WARNINGS_clang_png.c := unused-function, \
>
> This warning was disabled to fix the following build issue on linux and macOS.
>
>
> open/src/java.desktop/share/native/libsplashscreen/libpng/png.c:1558:1: error: 'png_icc_profile_error' defined but not used [-Werror=unused-function]
> [2025-03-12T23:57:44,575Z] 1558 | png_icc_profile_error(png_const_structrp png_ptr, png_const_charp name,
> [2025-03-12T23:57:44,575Z] | ^~~~~~~~~~~~~~~~~~~~~
Might this be a bug in PNG? All usages of this function are now guarded by "PNG_READ_iCCP_SUPPORTED"? It would be useful to report this upstream.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24021#discussion_r1994558215
More information about the client-libs-dev
mailing list