RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v2]

Manukumar V S mvs at openjdk.org
Tue Mar 18 18:37:11 UTC 2025


On Tue, 18 Mar 2025 17:52:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments fixed : Added SkippedException instead of forcePass(), Changed the position of imports, formatting changes
>
> test/jdk/java/awt/Desktop/MailTest.java line 63:
> 
>> 61:             PassFailJFrame.forcePass();
>> 62:             return;
>> 63:         }
> 
> A better and could be to move these checks into the `main` method and return right away without using `PassFailJFrame` at all. This would avoid creating and showing the UI before immediately disposing of it.
> 
> A `jtreg.SkippedException` could be thrown instead of passing the test — this way we'll be able to know if the test is never in an environment where it does perform the test actions.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24072#discussion_r2001737399


More information about the client-libs-dev mailing list