RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v2]
Manukumar V S
mvs at openjdk.org
Wed Mar 19 02:41:48 UTC 2025
On Tue, 18 Mar 2025 20:37:43 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments fixed : Added SkippedException instead of forcePass(), Changed the position of imports, formatting changes
>
> test/jdk/java/awt/Desktop/MailTest.java line 106:
>
>> 104: if (!desktop.isSupported(Desktop.Action.MAIL)) {
>> 105: String errorMessage = "Action.MAIL is not supported.";
>> 106: throw new SkippedException(errorMessage);
>
> Since the error message is used only once, you can inline the message to the constructor.
>
> You may inline `Desktop.getDesktop().isSupported(Desktop.Action.MAIL)` without introducing a local variable if you like.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24072#discussion_r2002311621
More information about the client-libs-dev
mailing list