RFR: 4466930: JTable.selectAll boundary handling [v4]
Tejesh R
tr at openjdk.org
Wed Mar 19 07:26:07 UTC 2025
On Wed, 19 Mar 2025 06:17:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 2188:
>>
>>> 2186: }
>>> 2187: if (rowCount > 0 && columnCount > 0) {
>>> 2188: selectRows(selectionModel, rowCount);
>>
>> Any reason for passing selectionModel(s) as parameters ? Anyhow they are class variables and can be used directly right ?
>
> Yes, good catch..we need to use local variable as done in old code and not modify the class variables..Modified to store the instance variable in local and use that..
[Here](https://github.com/openjdk/jdk/blob/577ede73d8e916bac9050d3bee80d2f18cc833a7/src/java.desktop/share/classes/javax/swing/JTable.java#L5629)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24025#discussion_r2002620303
More information about the client-libs-dev
mailing list