RFR: 8352109: java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported [v3]
duke
duke at openjdk.org
Wed Mar 19 15:08:09 UTC 2025
On Wed, 19 Mar 2025 02:41:48 GMT, Manukumar V S <mvs at openjdk.org> wrote:
>> **Issue**
>> java/awt/Desktop/MailTest.java fails in platforms where Action.MAIL is not supported
>>
>> **Reason**
>> In `MailTest.java`, there is a condition check(`if (!desktop.isSupported(Desktop.Action.MAIL))`) which will force pass the test if the corresponding 'Action' is not supported by the platform. But, apparently, this is not working good and the code flow went past this and fails in desktop.mail() method with an UnsupportedOperationException.
>>
>> **Fix**
>> Even though we are calling `PassFailJFrame.forcePass()` if the 'Action.MAIL' is unsupported, the PassFailJFrame just count downs a latch and the actual action will be taken later only(in `awaitAndCheck()`). But at the meantime, the desktop.mail() call gets executed in the constructor of MailTest() and it will result in an UnsupportedOperationException. So, the fix is to return from the constructor immediately if the operation is 'unsupported'.
>>
>> **Testing**
>> This is a manual test, so it is tested locally and found to be working fine.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments fixed : Removed unwanted variable, made the error message inline
@manukumarvs
Your change (at version 650f58854165d8f4e0358e4433baa7bd9c8491c3) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24072#issuecomment-2736985916
More information about the client-libs-dev
mailing list