RFR: 4466930: JTable.selectAll boundary handling [v7]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Mar 20 05:17:10 UTC 2025


On Thu, 20 Mar 2025 05:12:53 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add check for rowselection and columnselection
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 2190:
> 
>> 2188:         if (rowCount > 0 && columnCount > 0) {
>> 2189:             selectRows(rowCount);
>> 2190:             selectColumns(columnCount);
> 
> Here the checks are missing. Both row and column selection allowed check.

I know but it is not there in the code before the fix too..THere's no bug raised for that in JBS so I would like to continue with that for now so that we dont get any difference in behavior..I added the check in the new code..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24025#discussion_r2004825477


More information about the client-libs-dev mailing list