RFR: 4466930: JTable.selectAll boundary handling [v8]

Abhishek Kumar abhiscxk at openjdk.org
Thu Mar 20 08:18:12 UTC 2025


On Thu, 20 Mar 2025 07:59:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> JTable.selectAll doesn't do anything if there are no rows or no columns. 
>> But it should still select all columns if there are no rows and the other way round. 
>> It is seen that isColumnSelected() will return false for all columns after calling selectAll() if there happened to be no rows.
>> 
>> Fix is made to select all columns even if there are no rows and similarly for rows if there are no columns.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Merge condition

Thanks @prsadhuk for clarifying headful doubt offline.

LGTM.

-------------

Marked as reviewed by abhiscxk (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24025#pullrequestreview-2701637838


More information about the client-libs-dev mailing list