RFR: 8347826: Introspector shows wrong method list after 8071693 [v8]

Roman Marchenko rmarchenko at openjdk.org
Fri Mar 21 07:32:17 UTC 2025


On Thu, 20 Mar 2025 20:58:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing review comments 2
>
> test/jdk/java/beans/Introspector/DefaultMethodBeanPropertyTest.java line 409:
> 
>> 407:                     + expected.stream()
>> 408:                             .map(Object::toString)
>> 409:                             .collect(Collectors.joining("\n  ")));
> 
> Suggestion:
> 
>                     + expected.stream()
>                               .map(Object::toString)
>                               .collect(Collectors.joining("\n  ")));
> 
> The dots in chained calls were aligned; they remain aligned for `actual` but aren't aligned for `expected`.

This wasn't aligned with the dot above. This was aligned by 8 spaces, the same as for `actual`. But OK if you like.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r2007007167


More information about the client-libs-dev mailing list