RFR: 8347826: Introspector shows wrong method list after 8071693 [v8]

Roman Marchenko rmarchenko at openjdk.org
Fri Mar 21 07:44:12 UTC 2025


On Thu, 20 Mar 2025 21:08:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing review comments 2
>
> src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java line 81:
> 
>> 79:         if (!isInitedToIsGetter && this.readList != null) {
>> 80:             for (MethodInfo info : this.readList) {
>> 81:                 if ((this.read == null) || (!info.method.isDefault() && this.read.type.isAssignableFrom(info.type))) {
> 
> Suggestion:
> 
>                 if ((this.read == null) || (!info.method.isDefault()
>                                             && this.read.type.isAssignableFrom(info.type))) {
> 
> To avoid a rather long line; wrapping at `||` is also an option.

This file already contains lines which are the same length or much longer. But OK, if you like.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r2007020271


More information about the client-libs-dev mailing list