RFR: JDK-8346465 : Add a check in setData() to restrict the update of Built-In ICC_Profiles [v17]
Sergey Bylokhov
serb at openjdk.org
Fri Mar 21 22:51:15 UTC 2025
On Thu, 13 Mar 2025 20:25:26 GMT, Phil Race <prr at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> redudant stmt removed
>
> Marked as reviewed by prr (Reviewer).
@prrace I know that the CSR description is not part of the specification. But I would like to point out that we do not specify built-in profiles as singletons (but currently implemented as such). Therefore, it is not necessarily true that the same profile will always be returned by `getInstance` method.
>https://bugs.openjdk.org/browse/JDK-8350025
>The built-in profiles are singleton objects, if an application modifies a shared profile object via ICC_Profile.setData(), then the modified version of the profile is returned each time the same built-in profile is requested via ICC_Profile.getInstance(). This would impact all color space transformations using the modified color space.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23606#issuecomment-2744618698
More information about the client-libs-dev
mailing list