RFR: 8352890: Remove unnecessary Windows version check in FileFontStrike [v3]
Daniel Gredler
dgredler at openjdk.org
Wed Mar 26 21:14:24 UTC 2025
On Wed, 26 Mar 2025 17:31:14 GMT, Phil Race <prr at openjdk.org> wrote:
>> I'll defer to you and Phil on this one. The existing code base seems to use `memset` much more often than vanilla array init, even just for zeroes. I had also assumed that we would want to keep `initNative`, rather than initializing immediately, but I'm happy to eliminate it if my assumption was wrong.
>>
>> @prrace: Thoughts?
>
> initNative used to do more .. it used to actually check whether it was XP or later .. somewhere along the line that functionality was removed. Probably the method can be removed. But you'd have to be sure the initializer works, and I'd need to run it through the test system.
OK, the extra simplification looks like it's working correctly on my Win10 machine. Please have a look and submit that test run, when you get a chance. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24230#discussion_r2015005145
More information about the client-libs-dev
mailing list