RFR: 8352680: Opensource few misc swing tests

Abhishek Kumar abhiscxk at openjdk.org
Fri Mar 28 10:56:09 UTC 2025


On Fri, 28 Mar 2025 10:16:47 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Few JMenuItem and JFrame tests are opensourced..

test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 31:

> 29:  *     This test checks if menu items lay out correctly when their
> 30:  *     ComponentOrientation property is set to RIGHT_TO_LEFT.
> 31:  *     This test is manual. The tester is asked to compare left-to-right and

Not required to mention manual
Suggestion:

 *     The tester is asked to compare left-to-right and

test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 104:

> 102:     static JMenu createMenu(String laf, String name) {
> 103:         JMenu menu = new JMenu(name);
> 104:         try{

Suggestion:

        try {

test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 111:

> 109:             addMenuItems(menu, ComponentOrientation.RIGHT_TO_LEFT);
> 110:             UIManager.setLookAndFeel(save);
> 111:         } catch(Exception e){

Suggestion:

        } catch(Exception e) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24288#discussion_r2018402787
PR Review Comment: https://git.openjdk.org/jdk/pull/24288#discussion_r2018405942
PR Review Comment: https://git.openjdk.org/jdk/pull/24288#discussion_r2018405684


More information about the client-libs-dev mailing list