RFR: 8356208: Remove obsolete code in PSPrinterJob for plugin printing [v2]
Phil Race
prr at openjdk.org
Tue May 6 18:37:32 UTC 2025
On Tue, 6 May 2025 02:42:56 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8356208
>
> src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 272:
>
>> 270: /* non-null if printing EPS for Java Plugin */
>> 271: private EPSPrinter epsPrinter = null;
>> 272:
>
> This looks fine, but what about all unused xx_MASK and xx_SHIFT and hexDigits at the start of this class? and unused escapeParens() and mCurMetrics below?
I guess un-related to what I was deleting but I will add it in as these can't have been used in a long time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25047#discussion_r2076044668
More information about the client-libs-dev
mailing list