Integrated: 8354273: Replace even more Unicode characters with ASCII

Andrew Thompson lordpixel at mac.com
Tue May 6 22:48:06 UTC 2025


> I believe the source code of the JDK should be in US-ASCII

Why? This seems like a bizarre thing to believe free of context. 

In my experience using non-ascii regularly is the only way to make sure that tools which destroy non-ascii data are not introduced into tool chains which then break cases that matter. 

The downside of making things ascii is you miss when bugs are introduced. The upsides of using ascii everywhere are unclear to me. 

Also, if it’s 8 bit, it’s not ascii anyway. It’s really Latin-1 or code page-1252 or who knows what. Better to decide everything is utf-8 and fix tools which can’t handle that before they cause issues. 

Andrew 

> On May 6, 2025, at 2:04 PM, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> 
> On Thu, 10 Apr 2025 10:18:08 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> 
>> As a follow-up to [JDK-8354213](https://bugs.openjdk.org/browse/JDK-8354213), I found some additional places where unicode characters are unnecessarily used instead of pure ASCII.
> 
> This pull request has now been integrated.
> 
> Changeset: 08dd4a75
> Author:    Magnus Ihse Bursie <ihse at openjdk.org>
> URL:       https://git.openjdk.org/jdk/commit/08dd4a75c5b751a66d2e088b0ec9c6d6c443c14a
> Stats:     11 lines in 8 files changed: 0 ins; 1 del; 10 mod
> 
> 8354273: Replace even more Unicode characters with ASCII
> 
> Reviewed-by: naoto
> 
> -------------
> 
> PR: https://git.openjdk.org/jdk/pull/24567
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20250506/d3ad0729/attachment-0001.htm>


More information about the client-libs-dev mailing list