RFR: 8356137: GifImageDecode can produce opaque image when disposal method changes [v3]
Jeremy Wood
duke at openjdk.org
Wed May 7 02:58:01 UTC 2025
> This resolves a gif parsing bug where an unwanted opaque rectangle could appear under these conditions:
>
> 1. The disposal method for frames is 1 (meaning "do not dispose", aka "DISPOSAL_SAVE")
> 2. The transparent pixel is non-zero
> 3. There's more than one such consecutive frame
>
> Previously: the GifImageDecoder would leave the saved_image pixels as zero when they were supposed to be transparent. This works great if the transparent pixel index is zero, but it flood fills the background of your frame with the zeroeth color otherwise.
Jeremy Wood has updated the pull request incrementally with two additional commits since the last revision:
- 8356120: updating (c) year
- 8356137: cleaning up error message
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/25044/files
- new: https://git.openjdk.org/jdk/pull/25044/files/925d558c..c7072231
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=25044&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=25044&range=01-02
Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/25044.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25044/head:pull/25044
PR: https://git.openjdk.org/jdk/pull/25044
More information about the client-libs-dev
mailing list