Withdrawn: 8351913: ToolkitImage renders some gifs wrong

Jeremy Wood duke at openjdk.org
Sat May 10 19:02:00 UTC 2025


On Thu, 27 Mar 2025 03:40:05 GMT, Jeremy Wood <duke at openjdk.org> wrote:

> I do not have much background in LZW compression or in C, but I'm reasonably confident this resolves the problem I'm observing. It looks like the GifImageDecoder was not always correctly handling compression codes after the table reached its limit of ~4096. If anyone has suggestions for improvements I'm happy to make adjustments.
> 
> Luckily while debugging this: I was able to compare the flawed implementation (GifImageDecoder) with ImageIO's implementation (GIFImageReader) to help identify how the suffix/prefix tables are supposed to work.
> 
> ImageIO's implementation may have suffered a similar bug (maybe https://bugs.openjdk.org/browse/JDK-7131823 ?), and that appears to have been backported.
> 
> I have dozens of additional test cases for this problem, but unfortunately I don't have the rights to commit them to the OpenJDK repo. Feel free to email me for additional context/test cases.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/24271


More information about the client-libs-dev mailing list