RFR: 8356844: Missing @Serial annotation for sun.print.CustomOutputBin#serialVersionUID
Alexey Ivanov
aivanov at openjdk.org
Tue May 13 18:29:01 UTC 2025
On Tue, 13 May 2025 08:19:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> The serialVersionUID field in sun.print.CustomOutputBin is missing the `@Serial` annotation. This is the only one missing usage of `@Serial` in the java.desktop module. The class was introduced in [JDK-8314070](https://bugs.openjdk.org/browse/JDK-8314070), after the `@Serial` annotation was applied to java.desktop in [JDK-8259522](https://bugs.openjdk.org/browse/JDK-8259522).
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/sun/print/CustomOutputBin.java line 2:
> 1: /*
> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
Suggestion:
* Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
The year shouldn't be replaced but added.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25202#pullrequestreview-2837743112
PR Review Comment: https://git.openjdk.org/jdk/pull/25202#discussion_r2087407925
More information about the client-libs-dev
mailing list