RFR: 8323545: java/awt/GraphicsDevice/CheckDisplayModes.java fails with "exit code: 133" [v2]

Alexander Zuev kizune at openjdk.org
Tue May 13 20:46:38 UTC 2025


On Mon, 12 May 2025 23:56:45 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Caching getScreenDevices() output in a local variable.
>
> test/jdk/java/awt/GraphicsDevice/CheckDisplayModes.java line 42:
> 
>> 40:         }
>> 41: 
>> 42:         for (GraphicsDevice graphicDevice : ge.getScreenDevices()) {
> 
> I remember that, at least in ogl, querying/initializing devices can invalidate the list of existing devices on the fly. It might be better to call getScreenDevices only once, this could(or maybe not) increase the chances to catch the bug."

Ok, storing all devices in a local array to use it in both debug output and actual resolution testing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25179#discussion_r2087601289


More information about the client-libs-dev mailing list