RFR: 8355478: DoubleActionESC.java fails intermittently

[Anass Baya]

On Thu, 15 May 2025 15:17:47 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Hello @kumarabhi006,
>> Thank you for your review.
>> 
>> Did you try to reproduce the bug manually first with b25 before proceeding with the automated test ?
>> From my side, I proceed that way: I revert the fix on the mainline, the test fails 20/20 times.
>> Then, when I reapply the fix, the test passes 20/20
>
>> Did you try to reproduce the bug manually first with b25 before proceeding with the automated test ?
> 
> Yes, I tried with the manual applet test with b25 and b29.
> There is an exception thrown (related with security permission) for the first time whenever Show File Dialog button is clicked but on next click File Dialog is shown and it's getting closed on `ESC` press (Behaves same for repeat operations).
> 
> The behavior is same for b25 and b29 both.
> 
> For automated test, it's same behavior and there is no exception thrown.
> Debug prints for b25 and b29:
> 
>      Show File Dialog
>      Set File Dialog Visible
>      Press ESC Button
>      Before latch countDown : 2
>      After latch countDown : 1
>      Show File Dialog
>      Set File Dialog Visible
>      Press ESC Button
>      Before latch countDown : 1
>      After latch countDown : 0

@kumarabhi006 
As I understand, you're not able to reproduce the issue with b25( the version that doent include the fix), even when testing manually. So it's unclear whether the automated test is actually effective since you are not reproducing the issue manually

As I mentioned earlier, to check the test's effectiveness, I reverted the fix on the mainline — and the test failed 20 out of 20 times. Then, when I reapplied the fix, the test passed 20 out of 20 times.

Maybe you could try running the test in a loop. According to [JDK-5097243](https://bugs.openjdk.org/browse/JDK-5097243), the issue reproduction is intermittent

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25184#issuecomment-2884250541