RFR: 8356966: java/awt/Graphics2D/DrawString/IgnoredWhitespaceTest.java fails on Linux after JDK-8350203 [v2]
Alexey Ivanov
aivanov at openjdk.org
Thu May 15 16:16:57 UTC 2025
On Wed, 14 May 2025 21:40:47 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:
>> If the new test (`IgnoredWhitespaceTest`) runs on a system with Type1 physical fonts, it fails because the Type1 handling of ignorable whitespace characters does not match the behavior of the TrueType and macOS glyph mappers.
>>
>> This PR updates the Type1 glyph mapper to follow the same rules in this area as the other glyph mappers.
>>
>> It would probably be a good idea to consolidate all of this into the `CharToGlyphMapper` superclass at some point, so that we're not duplicating this handling across the subclasses, but some users are reporting failing builds and I wanted to keep the PR simple.
>
> Daniel Gredler has updated the pull request incrementally with one additional commit since the last revision:
>
> Include additional font information in message
Looks good to me.
I didn't try to reproduce the problem. Let's wait for @MBaesken test results.
test/jdk/java/awt/Graphics2D/DrawString/IgnoredWhitespaceTest.java line 1:
> 1: /*
Add 8356966 to the `@bug` tag in the test.
-------------
Changes requested by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25235#pullrequestreview-2844313205
PR Review Comment: https://git.openjdk.org/jdk/pull/25235#discussion_r2091546737
More information about the client-libs-dev
mailing list