RFR: 8356061: [macos] com/apple/laf/RootPane/RootPaneDefaultButtonTest.java test fails on macosx-aarch64 machine [v3]
Jeremy Wood
duke at openjdk.org
Mon May 19 05:37:06 UTC 2025
On Mon, 19 May 2025 02:11:35 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> I added an additional delay. I'm not sure exactly what refactor you're looking for, but I rewrote the test to put more in the EDT.
>>
>> (I double-checked that the test still passes, but that doesn't prove much since I've never reproduced a failure.)
>>
>> I did try at one point blocking the testing thread until the EDT had a chance to complete an invokeLater runnable, but that didn't seem to make a difference so I didn't commit it.
>
> The code in test() which access swing components(various buttons) also should be moved to EDT.
I'm not sure I agree, but that becomes moot after https://github.com/openjdk/jdk/pull/25244/commits/9f91249a424b190990fc3056644b5aac8caa0a5b
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25244#discussion_r2094867526
More information about the client-libs-dev
mailing list