RFR: 8357226: Remove unnecessary List.indexOf from RepaintManager.removeInvalidComponent
Sergey Bylokhov
serb at openjdk.org
Mon May 19 08:26:28 UTC 2025
On Thu, 24 Apr 2025 09:29:24 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
> No need to call `List.indexOf(Object)` before `List.remove(int)`. Instead we can call `List.remove(Object)` directly. It's faster and cleaner.
> `invalidComponents` is an ArrayList.
src/java.desktop/share/classes/javax/swing/RepaintManager.java line 394:
> 392: }
> 393: if (invalidComponents != null) {
> 394: invalidComponents.remove(component);
I guess the `addInvalidComponent` above can be simplified as well?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24845#discussion_r2065042601
More information about the client-libs-dev
mailing list