RFR: 8357176: java.awt javadoc code examples still use Applet API
Alexey Ivanov
aivanov at openjdk.org
Mon May 19 12:54:58 UTC 2025
On Fri, 16 May 2025 23:04:28 GMT, Phil Race <prr at openjdk.org> wrote:
> Update the some code examples and accompanying images to no longer mention or display as applets.
src/java.desktop/share/classes/java/awt/GridBagLayout.java line 243:
> 241: * right-to-left container.
> 242: *
> 243: * <div style="margin:0 auto;width:850px;text-align:center;font-weight:bold">
Is it possible to keep the width small as it was?
src/java.desktop/share/classes/java/awt/GridBagLayout.java line 288:
> 286: * public class GridBagLayoutExample {
> 287: *
> 288: * static void addButton(String name,
Suggestion:
* private static void addButton(String name,
src/java.desktop/share/classes/java/awt/GridBagLayout.java line 295:
> 293: * gridbag.setConstraints(button, c);
> 294: * frame.add(button);
> 295: * }
The `add` method should indented by 4 spaces to the right.
src/java.desktop/share/classes/java/awt/GridBagLayout.java line 303:
> 301: * GridBagLayout gridbag = new GridBagLayout();
> 302: * GridBagConstraints c = new GridBagConstraints();
> 303: * frame.setLayout(gridbag);
The `main` method should be indented by 4 spaces to the right, it's inside `GridBagLayoutExample` class.
src/java.desktop/share/classes/java/awt/MediaTracker.java line 108:
> 106: * tracker.addImage(bg, 0);
> 107: * for (int i = 0; i < 5; i++) {
> 108: * anim[i] = tk.getImage("anim"+i+".gif");
Suggestion:
* anim[i] = tk.getImage("anim" + i + ".gif");
src/java.desktop/share/classes/java/awt/doc-files/BorderLayout-1.png line 1:
> 1: �PNG
The images would look better with square borders… which are left on Windows 10 only.
If it's possible to make the pixels on the rounded corners transparent or at least white, the images would look better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2095631052
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2095624810
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2095625842
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2095627784
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2095635506
PR Review Comment: https://git.openjdk.org/jdk/pull/25278#discussion_r2095643191
More information about the client-libs-dev
mailing list