RFR: 8356061: [macos] com/apple/laf/RootPane/RootPaneDefaultButtonTest.java test fails on macosx-aarch64 machine [v3]
Jayathirth D V
jdv at openjdk.org
Tue May 20 11:19:58 UTC 2025
On Mon, 19 May 2025 05:37:05 GMT, Jeremy Wood <duke at openjdk.org> wrote:
>> Unfortunately I'm unable to reproduce this failure. I slowed the test down; it passes on my machine before and after this PR.
>>
>> I added a little bit of logging that might also help identify what's happening.
>>
>> Does anyone have any more suggestions?
>
> Jeremy Wood has updated the pull request incrementally with one additional commit since the last revision:
>
> 8356061: removing robot
>
> This is in response to:
> https://github.com/openjdk/jdk/pull/25244#issuecomment-2889420453
I think the original issue of getting same RGB color for both default and non-default button is happening because when we move mouse pointer to a location and pick the color from the same location using robot, sometimes it picks the color of mouse pointer and not UI component(this issue is observed only in macOS aarch64 machines).
Since we have completely removed usage of robot in this test case, we should not see same color for default and non-default buttons anymore. LGTM.
-------------
Marked as reviewed by jdv (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25244#pullrequestreview-2853766216
More information about the client-libs-dev
mailing list