RFR: 8357305: Compilation failure in javax/swing/JMenuItem/bug6197830.java

[Manukumar V S]

On Tue, 20 May 2025 12:03:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> > > I see that `MenuItemTest` class exists in `bug4729669.java`:
> > > https://github.com/openjdk/jdk/blob/e961b13cd68bc352b86af17c7e53df8537519beb/test/jdk/javax/swing/JMenuItem/bug4729669.java#L80
> > > 
> > > Is it similar to the one that you copied?
> > > If that `MenuItemTest` class is identical, I suggest moving both tests into a subdirectory and promoting `MenuItemTest` into a public class in that subdirectory which is located in its own `.java` file.
> > 
> > 
> > No, these are no exactly the same, the doMenuItemTest(boolean isLeft) method in bug4729669.java has only one parameter, but the doMenuItemTest(boolean isLeft, String lafName, int frameY) method has three parameters in bug6197830.java.
> 
> Can they be merged together?
> 
> If possible, I'd like to eliminate code duplication and extract common code.

Yes, I can try that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25319#issuecomment-2894168382